Jump to content

Photo

What's needed for SCS v31?


71 replies to this topic

#61 ALIENQuake

ALIENQuake
  • Modders
  • 576 posts
  • Gender:Male
  • Location:Poland

Posted 29 August 2018 - 04:31 AM

@Mad Mate I notice that you pushed this commit after I accepted PR#3. So this part of the fixes are missing as you can see here: https://github.com/G...atagems/network

 

Please create new PR so this fix can be added.



#62 Mad Mate

Mad Mate
  • Members
  • 190 posts
  • Gender:Male

Posted 29 August 2018 - 07:26 PM

Sorry, I'm new to this. I created new PR.
Is now better?
I see that fix made it to RC3 anyway.

#63 ALIENQuake

ALIENQuake
  • Modders
  • 576 posts
  • Gender:Male
  • Location:Poland

Posted 29 August 2018 - 09:43 PM

Yes, fix/commit was included for master but not for RevisedSCS. Also, I wanted to avoid confusion when somebody will look at the Network graph and see 'this tiny lite commit' outside of the main branch. Keep up good work!



#64 CamDawg

CamDawg

    ALL GLORY TO THE HYPNOTOAD

  • Gibberling Poobah
  • 9684 posts
  • Gender:Not Telling

Posted 29 August 2018 - 10:00 PM

 

 

Instantaneous 206/318/321/324 need altering to new filename on the new spell.
Durational 206/318/321/324 need cloning to new filename on the new and old spell.
Entries in 7eyes.2da need to be cloned for the new filename.

 

This. I couldn't have said it any better.

 

 

One nitpick--321 should be updated to reference both resources, e.g. a cloned Armor of Faith still shouldn't stack with its original.

 

 

And while I'm not going to try and address the spell cloning issue for SCS v31 (especially since David is revamping the system anyway), there is a shiny new function for anyone interested that will clone spells in accordance with the above directives.


Why is this Hypnotoad video so popu... ALL GLORY TO THE HYPNOTOAD.


#65 Luke

Luke
  • Members
  • 142 posts
  • Gender:Male

Posted 04 September 2018 - 12:37 PM

@DavidW

 

Do you plan to add support for IWD:EE in version 32? That would be great  :jump: ...........


Edited by Luke, 04 September 2018 - 12:38 PM.


#66 DavidW

DavidW
  • Gibberlings
  • 4431 posts
  • Gender:Male

Posted 04 September 2018 - 01:29 PM

@DavidW

 

Do you plan to add support for IWD:EE in version 32? That would be great  :jump: ...........

No.



#67 Luke

Luke
  • Members
  • 142 posts
  • Gender:Male

Posted 05 September 2018 - 12:54 AM

 

@DavidW

 

Do you plan to add support for IWD:EE in version 32? That would be great  :jump: ...........

No.

 

:( Is that something you'll address in future versions?

 

Alternatively, do you plan to add support for the mod IWDification in version 32? If I'm not mistaken, you're one of the authors of this mod, right?



#68 DavidW

DavidW
  • Gibberlings
  • 4431 posts
  • Gender:Male

Posted 05 September 2018 - 01:53 AM

I have a pretty general policy of not giving advance warning of things I plan to add, sorry!

#69 subtledoctor

subtledoctor
  • Modders
  • 2639 posts
  • Gender:Male

Posted 08 September 2018 - 02:37 PM

Sorry to go off-topic, btu everyone who seems to know anything about Detectable Spells has been in this thread.  Can anyone take a look at the version in SR v4b15 and let me know whether/how it needs updating?  That SR version looks very very different from the DS.tph on Github, and I don't want to mess with it because I think I might break something.  But I'm making an update to SR and I'd like to be sure it works well with EE v2.5. 

 

If anyone can take a look, please feel free to post about it in the linked thread.

 

Thanks!  I'll go now.


Faiths & Powers: Spell spheres and kit pack for priests and paladins
Might & Guile: Tweaks and kits for warriors and rogues
Scales of Balance: Game tweaks and rule overhauls
NPC_EE: More options for NPCs in BGEE, SoD, & BG2EE


#70 Mad Mate

Mad Mate
  • Members
  • 190 posts
  • Gender:Male

Posted 08 September 2018 - 04:35 PM

Sorry to go off-topic, btu everyone who seems to know anything about Detectable Spells has been in this thread.  Can anyone take a look at the version in SR v4b15 and let me know whether/how it needs updating?  That SR version looks very very different from the DS.tph on Github, and I don't want to mess with it because I think I might break something.  But I'm making an update to SR and I'd like to be sure it works well with EE v2.5. 

 

If anyone can take a look, please feel free to post about it in the linked thread.

 

Thanks!  I'll go now.

It is same DS, if you mean SCS one. SR4 was source of new DS and only changes are few compatibility lines in start that are useful for old mods (like SCS) that use old names for functions and macros. SR4 uses only new names, so those few lines wouldn't do anything. Of course, adding those lines wouldn't hurt.



#71 subtledoctor

subtledoctor
  • Modders
  • 2639 posts
  • Gender:Male

Posted 08 September 2018 - 08:46 PM

It is same DS, if you mean SCS one.


Operative question is, does SR need to be fixed for the 2.5 patch? I.e. (I think) does it need this:
SORT_ARRAY_INDICES auxil NUMERICALLY
?

Faiths & Powers: Spell spheres and kit pack for priests and paladins
Might & Guile: Tweaks and kits for warriors and rogues
Scales of Balance: Game tweaks and rule overhauls
NPC_EE: More options for NPCs in BGEE, SoD, & BG2EE


#72 Ardanis

Ardanis

    A very GAR character

  • Modders
  • 2604 posts
  • Gender:Male
  • Location:Saint-Petersburg, Russia

Posted 08 September 2018 - 10:11 PM

 

It is same DS, if you mean SCS one.


Operative question is, does SR need to be fixed for the 2.5 patch? I.e. (I think) does it need this:
SORT_ARRAY_INDICES auxil NUMERICALLY
?

 

 It's identical to

  SPRINT sort_array auxil
  LPM sort_array

present in v3.95

If you're concerned whether it's better to just use internal WeiDU function, then technically that's what I would've wanted back then. However, if memory serves me well, my macro had a bit of edge over Wisp's implementation either in being able to sort both numerically and lexically in one sweep or somehow else, so I'd rather preserve my macro somewhere in case anybody would ever need its functionality. For the purpose of fixing the v2.5 bug it makes no difference which one is used.


Edited by Ardanis, 08 September 2018 - 10:22 PM.

Retired from modding.




Reply to this topic



  


1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users