Item usability flags

[igi]

BUG:

"Gloves of Pickpocketing and Ring of Danger Sense could be worn by many classes who can neither pick pockets nor find traps"

 

CAUSE:

Incorrect usability flags.

 

FIX:

Correct usability flags (only class's/kits that can pick pockets or detect traps)

COPY_EXISTING ~brac17.itm~ ~override/brac17.itm~
 WRITE_BYTE "0x001f" "253"
 WRITE_BYTE "0x0020" "52"
 WRITE_BYTE "0x0021" "96"

 WRITE_BYTE "0x0029" "255"
 WRITE_BYTE "0x002b" "3"
 WRITE_BYTE "0x002d" "191"
 WRITE_BYTE "0x002f" "255"
 BUT_ONLY_IF_IT_CHANGES

COPY_EXISTING ~ring36.itm~ ~override/ring36.itm~
 WRITE_BYTE "0x001f" "253"
 WRITE_BYTE "0x0020" "52"
 WRITE_BYTE "0x0021" "96"

 WRITE_BYTE "0x0029" "255"
 WRITE_BYTE "0x002b" "3"
 WRITE_BYTE "0x002d" "191" // baseclass
 WRITE_BYTE "0x002f" "255"
 BUT_ONLY_IF_IT_CHANGES

 

NB. We may want to edit the description to reflect the new usability restrictions.

[SimDing0]

Yes, definitely edit the text.

[Kish]

Wait a minute. If the description doesn't say they can only be worn by thieves, and the rings can't only be worn by thieves--what's the bug? Why are we assuming people should be physically incapable of putting on magical rings that won't do anything for them?

[SimDing0]

Isn't that how other items in the game work?

[Andyr]

I say leave them wearable but useless- it adds more work and it another thing that could go wrong. The game is not always consistent about whether you can wear useless items or not.

[igi]

The work is already done, so just ake it or leave it.

Someone should find out how the game treats other similar items and base a decision on that.

[Kish]

Heh. Whichever is the majority gets to convert the minority items? :-p

 

The Boots of Stealth can be used by anyone who qualifies for the bonus (thieves and rangers) and not those who don't. The Ring of Wizardry and the Ring of Acuity are usable only by mages (wizards/sorcerers), although bards could also benefit from them. Robes are only usable by mages though they have benefits for anyone. The Ring of Holiness is cleric or druid, but not ranger or paladin. The two items in question, the Gloves of Pickpocketing and Ring of Danger Sense, can be used by anyone. The game really has no indication of a single "right way" for all items.

[SimDing0]

It seems to me that the pattern is "items are not necessarily usable by all classes to which they may convey bonuses", but there don't appear to be any further examples of "items are usable by classes to which they may not convey bonuses". I'd make the distinction here in terms of modifying usability and description.

[igi]

Updated to be more patchy:

 

COPY_EXISTING ~brac17.itm~ ~override/brac17.itm~
 READ_BYTE "0x001e" "1e"
 WRITE_BYTE "0x001e" (%1e% BOR  0b10000000)
 READ_BYTE "0x001f" "1f"
 WRITE_BYTE "0x001f" (%1f% BOR  0b11111101)
 READ_BYTE "0x0020" "20"
 WRITE_BYTE "0x0020" (%20% BOR  0b00110100)
 READ_BYTE "0x0021" "21"
 WRITE_BYTE "0x0021" (%21% BOR  0b01100000)

 READ_BYTE "0x0029" "29"
 WRITE_BYTE "0x0029" (%29% BOR  0b11111111)
 READ_BYTE "0x002b" "2b"
 WRITE_BYTE "0x002b" (%2b% BOR  0b00000011)
 READ_BYTE "0x002d" "2d"
 WRITE_BYTE "0x002d" (%2d% BOR  0b10111111)
 READ_BYTE "0x002f" "2f"
 WRITE_BYTE "0x002f" (%2f% BOR  0b11111111)
 BUT_ONLY_IF_IT_CHANGES
 BUT_ONLY_IF_IT_CHANGES

COPY_EXISTING ~ring36.itm~ ~override/ring36.itm~
 READ_BYTE "0x001e" "1e"
 WRITE_BYTE "0x001e" (%1e% BOR  0b10000000)
 READ_BYTE "0x001f" "1f"
 WRITE_BYTE "0x001f" (%1f% BOR  0b11111101)
 READ_BYTE "0x0020" "20"
 WRITE_BYTE "0x0020" (%20% BOR  0b00110100)
 READ_BYTE "0x0021" "21"
 WRITE_BYTE "0x0021" (%21% BOR  0b01100000)

 READ_BYTE "0x0029" "29"
 WRITE_BYTE "0x0029" (%29% BOR  0b11111111)
 READ_BYTE "0x002b" "2b"
 WRITE_BYTE "0x002b" (%2b% BOR  0b00000011)
 READ_BYTE "0x002d" "2d"
 WRITE_BYTE "0x002d" (%2d% BOR  0b10111111)
 READ_BYTE "0x002f" "2f"
 WRITE_BYTE "0x002f" (%2f% BOR  0b11111111)
 BUT_ONLY_IF_IT_CHANGES

[SimDing0]

Is this included?

[CamDawg]

Included in alpha 4.

[CamDawg]

And reviving an old topic, it looks like we got this dead wrong--the Ring of Danger Sense comes equipped on the ToB Mage character file, implying that it is supposed to be usable by all.

[SimDing0]

I don't buy that. It's not unheard of for them to get the ToB starting equipment wrong, and it smacks of an error that mages can start wearing something utterly useless to them.

[devSin]

I agree. "Fix" 25StWeap instead of leaving the ring with stupid usability.

[CamDawg]

All of the ToB starting items are usable by their class/kits--my original reports re: druids and fighter/druids was a mistake.

 

Which of these two scenarios is more likely:

1. Bioware wants Ring of Danger Sense to only be usable by thieves. They fail to note this in the description, the usability flags are wrong in the item, and it comes equipped on a ToB character file mage.
   
2. Bioware wants Ring of Danger Sense to be usable by all, though it provides no benefit.
   

While I'm usually the one quick to dog Bioware for sloppiness, #1 seems unlikely even by my standards. It doesn't make any sense that it's usable by mages but it is probably (and unfortunately) intentional.