Jump to content


Photo

Small bugs in DLGV1 and BIFCV1 formats


3 replies to this topic

#1 Calhavintas

Calhavintas

    Chaotic Good Mage

  • Members
  • 19 posts
  • Gender:Male
  • Location:Northern Germany

Posted 10 August 2017 - 03:44 AM

Hello there :)

 

the definitions for the DLGV1 and the BIFCV1 format contains some small errors:

 

  • DLGV1: the version constant in the header is 5 characters long (only 4 allowed)
  • BIFCV1: the last three offsets are shifted 4 bytes too far. Checked with icewind dale reference data

I patched them and created a pull request containing 2 commits, one for each format

 

By the way, the IESDP is a massive help for interpreting the infinity engine file formats.

Big thanks

 

UPDATE: added a commit to fix all inconsistencies regarding signatures and versions (amount of whitespaces, braces, char array type)


Edited by Calhavintas, 10 August 2017 - 04:27 AM.


#2 lynx

lynx
  • Modders
  • 3031 posts
  • Gender:Male
  • Location:Ljubljana, Slovenija

Posted 10 August 2017 - 04:49 AM

Great, I'll take a look!


GemRB - IE anywhere.
Mages needed! Looking for Planescape: Torment testers
Market android version IS NOT SUPPORTED ANYMORE: reported bugs will be ignored! Still looking for builders ...

#3 Calhavintas

Calhavintas

    Chaotic Good Mage

  • Members
  • 19 posts
  • Gender:Male
  • Location:Northern Germany

Posted 10 August 2017 - 05:07 AM

You're welcome :)

 

Are there other things, i could help with?



#4 lynx

lynx
  • Modders
  • 3031 posts
  • Gender:Male
  • Location:Ljubljana, Slovenija

Posted 10 August 2017 - 05:38 AM

Sure, plenty of them, both content and infrastructure related.


GemRB - IE anywhere.
Mages needed! Looking for Planescape: Torment testers
Market android version IS NOT SUPPORTED ANYMORE: reported bugs will be ignored! Still looking for builders ...



Reply to this topic



  


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users