Jump to content

Photo

SR Revised V1.0.4 + A List of Problems with b15 + Fixing Them


229 replies to this topic

#226 Jarno Mikkola

Jarno Mikkola

    The Imp

  • Modders
  • 6792 posts
  • Gender:Male
  • Location:The town where the dead haven't keeled over, yet. In Finland.

Posted Yesterday, 11:45 PM

There are a few things we haven't done yet for v4 - the docs need updating, especially the spell information.

Actually that would be better to just link to a new topic that contains the stuff. Not include it to a static version that's no where to be found on the internet except the install file ... as that way, you could update it during the time you have on the internet, and not during you fix stuff that need to be.. and then link the topics forward and backwards and lock the old topic when a new one comes out. This way you can hop between versions without a need to have a specific change log.

Edited by Jarno Mikkola, Yesterday, 11:52 PM.

Welcome to the sanity, you are free to search for the limit, it's out there, we drew it in the sand.
Here's how to install all the ... mods you ever really could want to Infinity Engine games. I removed the stable word from there as Roxanne began to add BS mods that are likely to break compatibility from the BWS.

#227 Bartimaeus

Bartimaeus
  • Members
  • 379 posts
  • Gender:Not Telling

Posted Today, 01:11 AM

Thanks, Subtledoctor. Question: what is the new Greater/Whirlwind stuff in spell_rev\lib\kreso_hla.tph for?

 

Also, your d5_set_spell_schools calls for "d5/dvscrlmap.2da", but d5/ is obviously not Spell Revisions.


Edited by Bartimaeus, Today, 01:51 AM.


#228 subtledoctor

subtledoctor
  • Modders
  • 2775 posts
  • Gender:Male

Posted Today, 10:06 AM

Issue a pull request and we can release it as b16.

I think it's worth tackling the bit about some AoE spells not being blocked by Spell Deflection, first. 
 
On that: Bartimeus has opined that Spell Deflection should not block AoE HLAs, because, I guess, they are HLA super spells.  I don't really buy that.  IMHO "blocks AoE magical effects" should mean "blocks AoE magical effects."
 
What I could buy is an argument that spells which bypass MR should also bypass Spell Deflection.  I actually don't really buy this, but I am aware of my (possibly irrational) antipathy toward MR, which might be blinding me.  So it might be worth a conversation if anyone wants to try to sell me on it.  Ditto for HLAs. 
 

Thanks, Subtledoctor. Question: what is the new Greater/Whirlwind stuff in spell_rev\lib\kreso_hla.tph for?

Dunno. I haven't touched that file as far as I know. Is it part of the "Revised Warrior HLAs" component?  I have the very vaguest memory of Demi turning the Whirlwind HLAs into something more like a sustained Gust of Wind ability...

You wanna know what's amazing? I haven't played BG2 in so long that I did a test install of my SR build on it, and I was baffled and had no memory of that component existing. Was like "wtf I've never seen this before!"  Serious question: why does that component exist?  Shouldn't that stuff be in Kit Revisions?  (But maybe the answer is "no" because KR is dead in the water...)
 

Also, your d5_set_spell_schools calls for "d5/dvscrlmap.2da", but d5/ is obviously not Spell Revisions.

The file is created in the code and then copied over as it is patched. My rough understanding is, creating it in the code involves the assumption of a virtual directory. The "d5/" directory doesn't actually (and need no actually" exist anywhere. That's the extent of my understanding - I parroted this from code in another mod.

Generally, I tried to use my own modder prefix where I added stuff. I don't think a mod needs to be monolithic in its use of prefixes; check out Refinements or Faiths & Powers for an example of multiple prefixes being used in a collaboration. Or, I assume, Tweaks Anthology. Not many things here bear the "d5" stamp, but for those that do, I want it to be clear that any issues arising related to those few items can be brought to my attention, and hopefully I can help make troubleshooting/fixing things easier.


Faiths & Powers: Spell spheres and kit pack for priests and paladins
Might & Guile: Tweaks and kits for warriors and rogues
Scales of Balance: Game tweaks and rule overhauls
NPC_EE: More options for NPCs in BGEE, SoD, & BG2EE


#229 Mike1072

Mike1072
  • Gibberling Poobah
  • 2487 posts
  • Gender:Male
  • Location:Canada

Posted Today, 11:29 AM

Issue a pull request and we can release it as b16.

I think it's worth tackling the bit about some AoE spells not being blocked by Spell Deflection, first.

If it's not ready for testing, that's fine. If it is, we should release a new beta. We don't want people going to your repo and downloading your master branch.
 

Also, your d5_set_spell_schools calls for "d5/dvscrlmap.2da", but d5/ is obviously not Spell Revisions.

The file is created in the code and then copied over as it is patched. My rough understanding is, creating it in the code involves the assumption of a virtual directory. The "d5/" directory doesn't actually (and need no actually" exist anywhere. That's the extent of my understanding - I parroted this from code in another mod.

Yes, this should work fine. Most of the time, we call out those inlined files by naming them ~.../inlined/blahblah~ so when you see something that interacts with it, you can tell that it's not looking for something in the file system.

#230 Bartimaeus

Bartimaeus
  • Members
  • 379 posts
  • Gender:Not Telling

Posted Today, 11:33 AM

Ignore what I said about the HLA thing - I appear to have compared the wrong two versions of the file and got confused. As for why it's here...I believe it's actually a kreso addition in one of his last betas.

Spell Deflection is limited by level, though. Minor Spell Deflection, for example, only blocks up to...I think 4th level, right? That's the basis I'm going by, as I think of HLAs as level 10 spells, which is beyond the normal limits of standard protection spells like Spell Deflection. I wonder how P&P would handle epic spells - would they really be deflected the same as any other 9th level spells? Feels like there should be a difference between your standard Power Word Kill and a Hellball, no?

Got it. Since the code is borrowed from whatever this d5 is, we might as well keep it that way.

For the AoE SD problem, I was thinking we could just side-step the entire issue of the renaming function by separating the self/single-targeted stuff from the AoE stuff to begin with and just putting the AoE stuff in a dv-prefixed .spl, and then adding that dv-prefixed spell to the AoE SD list. This would only be necessary for the handful of spells that actually need it (Chain Lightning, Wail of the Banshee, Fireburst, and Gust of Wind, I believe - False Dawn and Repulsion still cannot be deflected, I don't think, because of how they send out a once per round spell pulse that would trigger Spell Deflection each time and waste huge amounts of charges).

Edited by Bartimaeus, Today, 11:50 AM.




Reply to this topic



  


2 user(s) are reading this topic

0 members, 2 guests, 0 anonymous users