Jump to content

Photo

Issues with Spell Casting Sound Effects


9 replies to this topic

#1 skellytz

skellytz
  • Members
  • 9 posts
  • Gender:Not Telling

Posted 23 July 2017 - 07:46 AM

Hi!

 

I've found a bunch of minor issues that have probably never been addressed by any of the available community fixpacks. These typically involve incorrect casting animations, schools and effect parameters. I don't think it would be a good idea to spread these fixes across multiple mods; BG2 Fixpack is their right place.

 

I've double-checked everything to make sure the issues haven't already been covered by the new version of the fixpack, but naturally I may have missed something. Apologies for any false alarms and your wasted time.

 

Here we go.

 

1. Incorrect spell casting animation & associated hardcoded sound effect

 

- Holy Power (SPPR412) should be Invocation.

 

- Farsight (SPPR415) should be Divination.

 

- Lesser Restoration (SPPR417) should be Necromancy.

 

- Repulse Undead (SPPR515) should be Abjuration.

 

- Insect Plague (SPPR517) should be Conjuration.

 

- Creeping Doom (SPPR717) should be Conjuration.

 

- NPC Symbol, Death (SPWI897) should be Conjuration.

 

- NPC Symbol, Stun (SPWI898) should be Conjuration.

 

- NPC Symbol, Fear (SPWI899) should be Conjuration.

 

- Wild Surge Repulse Undead (SPWM101) should be Abjuration.

 

- Wild Surge Symbol, Fear (SPWM123) should be Conjuration.

 

2. Incorrect spell primary casting school

 

- Restore Full Health (SPIN746) should be Necromancer.

 

- Cutscene Flesh to Stone (SPIN950) should be Transmuter.

 

- Cutscene Power Word, Kill (SPIN951) should be Conjurer.

 

- Negative Plane Protection (SPPR413) should be Abjurer.

 

- Lesser Restoration (SPPR417) should be Necromancer.

 

- Conjure Animals (SPPR604) should be Conjurer.

3. Incorrect spell sound effect parameters

 

- Innate Larloch's Minor Drain (SPIN104) plays EFF_M07 with wrong target type (should be 2), timing mode (should be 1) and duration (should be 0). Compare with the Mage variant (SPWI119).

 

- Innate Horror (SPIN105) plays EFF_E05 with wrong duration (should be 18) or horror effect duration should be 60 like in the fixed Mage variant (SPWI205). There also seems to be a morale break effect which isn't present in the Mage variant; its parameters should be adjusted accordingly.

 

- Innate Protection from Evil (SPIN121) plays EFF_E04 with wrong target type (should be 2), timing mode (should be 4) and duration (should be 60).

 

- Grease (SPWI101) shouldn't have the hostile flag on. This causes the unfortunate battle music loop. No other AoE-stopping spells have this flag on.

 

- Mage Remove Curse (SPWI410) plays wrong visual effect (should be SPRMCURS). Compare with the Priest variant (SPPR307).

 

- Time Stop (SPWI909, SPWISH17) plays EFF_M91 with wrong duration (should be set to half of the Time Stop effect duration due to the quirks of opcode 231).

 

And that's it! (That is, at least when it comes to the non-arbitrary stuff.) Thanks ;)


Edited by skellytz, 25 July 2017 - 06:29 AM.


#2 CamDawg

CamDawg

    ALL GLORY TO THE HYPNOTOAD

  • Gibberling Poobah
  • 9724 posts
  • Gender:Not Telling

Posted 23 July 2017 - 08:32 AM

Looks solid, thanks for this. A few initial thoughts:
 

- [unused?] Repulse Undead (SPWM101) should be Abjuration.
 
- [unused?] Symbol Fear (SPWM123) should be Conjuration.


SPWM spells are wild surges. However, I'm pretty sure that when a wild surge occurs it still uses the original spell's casting animation, but I'll double check.
 

- Cutscene Flesh to Stone (SPIN950) should be Transmuter.
 
- Cutscene Power Word, Kill (SPIN951) should be Conjurer.


I'll take a look, but cutscene spells are often deliberately different from their underlying spells to make sure they always work. I don't think that's the case here, though.

Why is this Hypnotoad video so popu... ALL GLORY TO THE HYPNOTOAD.


#3 skellytz

skellytz
  • Members
  • 9 posts
  • Gender:Not Telling

Posted 25 July 2017 - 06:48 AM

 SPWM spells are wild surges. However, I'm pretty sure that when a wild surge occurs it still uses the original spell's casting animation, but I'll double check.

Yeah, but it looks like SPWM101 really isn't used in-game due to a bug. If you take a look inside the exe, the hardcoded wild surge table lists SPWM102 twice in a row:

SPWM102 SPWM102 SPWM103 SPWM104 SPWM105 (...)

This initially even carried over to the externalized table in BGEE:

           SPELL      STRREF
1          SPWM102    31718
2          SPWM102    31718
3          SPWM103    31719
4          SPWM104    31720
5          SPWM105    31721

You know, when it comes to Nahal's Reckless Dweomer, Chaos Shield, Improved Chaos Shield along with all the Wild Surges, the intention might have been to mess up the casting animation and sound effect on purpose. It's wild magic after all. It's hard to tell, what with all the other spells that have incorrect schools.

 

Still, I'd go for consistency here, even if it only applies to what Near Infinity displays in the fields.



#4 CamDawg

CamDawg

    ALL GLORY TO THE HYPNOTOAD

  • Gibberling Poobah
  • 9724 posts
  • Gender:Not Telling

Posted 29 July 2017 - 12:47 PM

Alright, I've got this sorted for beta 3.


Why is this Hypnotoad video so popu... ALL GLORY TO THE HYPNOTOAD.


#5 lynx

lynx
  • Modders
  • 3139 posts
  • Gender:Male
  • Location:Ljubljana, Slovenija

Posted 29 July 2017 - 01:17 PM

Yeah, the table got copied from gemrb which had the values from the exe.


GemRB - IE anywhere.
Mages needed! Looking for Planescape: Torment testers
Play android version IS NOT SUPPORTED ANYMORE: reported bugs will be ignored! Still looking for builders ...


#6 skellytz

skellytz
  • Members
  • 9 posts
  • Gender:Not Telling

Posted 23 December 2017 - 04:30 PM

Thank you for including the fixes in Beta 3/4!

 

I've gone through them in NI and it seems Lesser Restoration (SPPR417) still has wrong casting animation (should be Necro).



#7 CamDawg

CamDawg

    ALL GLORY TO THE HYPNOTOAD

  • Gibberling Poobah
  • 9724 posts
  • Gender:Not Telling

Posted 23 December 2017 - 05:03 PM

No, thank you for providing fixes. :) I'll get Lesser Restoration sorted for the next release.


Why is this Hypnotoad video so popu... ALL GLORY TO THE HYPNOTOAD.


#8 Andrea C.

Andrea C.
  • Members
  • 68 posts
  • Gender:Male
  • Location:Italy

Posted 18 February 2018 - 06:50 AM

CamDawg,

Are these fixes also going to be part of v2.5 of the Enhanced Editions?

#9 CamDawg

CamDawg

    ALL GLORY TO THE HYPNOTOAD

  • Gibberling Poobah
  • 9724 posts
  • Gender:Not Telling

Posted 18 February 2018 - 08:50 AM

Yes, and I'm pretty sure they're already in the betas.


Why is this Hypnotoad video so popu... ALL GLORY TO THE HYPNOTOAD.


#10 CamDawg

CamDawg

    ALL GLORY TO THE HYPNOTOAD

  • Gibberling Poobah
  • 9724 posts
  • Gender:Not Telling

Posted 05 October 2018 - 04:59 PM

Lesser restoration casting animation fix is in v12.


Why is this Hypnotoad video so popu... ALL GLORY TO THE HYPNOTOAD.




Reply to this topic



  


0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users