Jump to content

Photo

GemRB/TobEx opcode 318 (0x13e) differences

opcode tobex gemrb scs

4 replies to this topic

#1 bnoabody

bnoabody
  • Members
  • 2 posts
  • Gender:Not Telling

Posted 13 April 2018 - 07:45 AM

Another FYI:

 

Latest gemrb from git, files affected:

FXOpcodes.cpp:
// 0x13e ChangeWeather
// sets the weather to param1, set it to:
// 0 normal weather
// 1 rain
// 2 snow
// 3 fog

effects.ids:
0x13e ChangeWeather

wildmag.2da:
5          SPWM105    0x13e      *

Latest TobEx, files affected:

TobEx_ini.txt:
Description
#318 (0x13E)  Stat: Set stat [318]
Parameter #1: Statistic Modifier
Parameter #2 low: Stat Opcode
Parameter #2 high: Type

After Sword Coast Strategems install this entry is found in console log:

[Unknown]: fx_change_weather(318): P1: 1

Rain is present upon most level transitions, acompanied by either a mind-numbingly loud thunder-crack or the sound of a door slamming shut.  

Full Baldur's Gate Trilogy install with BG1/2 pre-patched to recommended version (Atari DnD Anthology).  Manual install of mods in this order; BiG word fixpack v17, Baldur's Gate Trilogy 118, ScS v30, lolfixer github, generalized biffing, widescreen 3.07.

Clearly there is a difference in the way effect opcode 318 (0x13E) is being implemented by GemRB and TobEx.  ScS appears to use this in its core components.



#2 lynx

lynx
  • Modders
  • 3122 posts
  • Gender:Male
  • Location:Ljubljana, Slovenija

Posted 14 April 2018 - 07:21 AM

First, you're not comparing the same thing. Tobex doesn't do anything to this opcode, since it wasn't present in the engine before ee. It has a different opcode at that address (Stat: Set stat), the new one is at 0x140.

 

Installing tobex doesn't affect gemrb, but this is about the numbering collision, since the ids files are in conflict. And then missing functions — I think the new setstat is just for the extra mode that ensures ordering.

 

That log line is perfectly fine.


GemRB - IE anywhere.
Mages needed! Looking for Planescape: Torment testers
Play android version IS NOT SUPPORTED ANYMORE: reported bugs will be ignored! Still looking for builders ...


#3 Avenger

Avenger
  • Modders
  • 3800 posts
  • Gender:Male
  • Location:Hungary

Posted 14 April 2018 - 11:16 AM

GemRB is pretty flexible to reassign the opcode numbers, though. So, if it implements an opcode (it does implement weather), you can make it mimic both TobEx or EE.



#4 lynx

lynx
  • Modders
  • 3122 posts
  • Gender:Male
  • Location:Ljubljana, Slovenija

Posted 14 April 2018 - 12:07 PM

Yeah, I'll just fix that one spell it was created for and assign it a higher number — it predates ee. It's the only conflicting id on the tobex list too.


GemRB - IE anywhere.
Mages needed! Looking for Planescape: Torment testers
Play android version IS NOT SUPPORTED ANYMORE: reported bugs will be ignored! Still looking for builders ...


#5 lynx

lynx
  • Modders
  • 3122 posts
  • Gender:Male
  • Location:Ljubljana, Slovenija

Posted 15 April 2018 - 04:51 AM

Ok, both things should work now. ChangeWeather has the same id and SetStat is supported (though tobex made it very limited).

 

Couldn't grep any uses in SCS though, so ???


GemRB - IE anywhere.
Mages needed! Looking for Planescape: Torment testers
Play android version IS NOT SUPPORTED ANYMORE: reported bugs will be ignored! Still looking for builders ...




Reply to this topic



  



1 user(s) are reading this topic

0 members, 1 guests, 0 anonymous users